[Nuxeo-tickets] Re: [Nuxeo Repository] #1822: CPSSkins box titles should use semantic header markup (h1 or h2)

[Nuxeo Repository]

#1822: CPSSkins box titles should use semantic header markup (h1 or h2)
---------------------------+------------------------------------------------
 Reporter:  madarche       |        Owner:  madarche 
     Type:  defect         |       Status:  new      
 Priority:  P2             |    Milestone:  CPS 3.5.0
Component:  CPSSkins       |      Version:  TRUNK    
 Severity:  normal         |   Resolution:           
 Keywords:  accessibility  |  
---------------------------+------------------------------------------------
Comment (by madarche):

 Here is the patch :
 {{{
 Index: SimpleBox.py
 ===================================================================
 --- SimpleBox.py        (révision 51394)
 +++ SimpleBox.py        (copie de travail)
 @@ -30,7 +30,7 @@

  BOX_LAYOUTS = {
      'standard': {
 -        'markup': """<div class="title">%s</div>
 +        'markup': """<h2 class="title">%s</div>
                       <div class="body">%s</div>""",
          },

 @@ -51,7 +51,7 @@
          },

      'no_frames': {
 -        'markup': """<div class="title" style="border: none">%s</div>
 +        'markup': """<h2 class="title" style="border: none">%s</div>
                       <div class="body" style="border: none">%s</div>
                    """,
          },
 @@ -59,7 +59,7 @@
      'rounded_box': {
          'markup': """<div class="cpsskinsBoxCorners">
                       <div class="rbtop"><div></div></div>
 -                     <div class="title">%s</div>
 +                     <h2 class="title">%s</div>
                       <div class="body">%s</div>
                       <div class="rbbot"><div></div></div></div>
                    """,
 Index: skins/CPSSkins/cpsskins_portalboxshape.dtml
 ===================================================================
 --- skins/CPSSkins/cpsskins_portalboxshape.dtml (révision 51394)
 +++ skins/CPSSkins/cpsskins_portalboxshape.dtml (copie de travail)
 @@ -1,4 +1,5 @@
  <dtml-let class="'.boxShape' + title">
 +<dtml-var class> h2.title,
  <dtml-var class> .title {
  <dtml-if BoxTitle_border_style>
    border-style: <dtml-var BoxTitle_border_style>;
 @@ -13,7 +14,7 @@
    display: <dtml-var BoxTitle_display>;
  </dtml-if>
  <dtml-if BoxTitle_font>
 -  font: <dtml-var BoxTitle_font>;
 +  font: <dtml-var BoxTitle_font>!important;
  </dtml-if>
  }
 }}}

-- 
Ticket URL: <http://svn.nuxeo.org/trac/pub/ticket/1822>
Nuxeo Repository <http://www.cps-project.org/>
Nuxeo Repository